]> dgit.raspbian.org Git - gnome-shell.git/commit
dialog: Check whether text changed when setting title or description
authorJonas Dreßler <verdre@v0yd.nl>
Sun, 28 Jun 2020 11:06:26 +0000 (13:06 +0200)
committerFlorian Müllner <florian.muellner@gmail.com>
Mon, 29 Jun 2020 10:17:07 +0000 (10:17 +0000)
commite4bb2037ca16a7f6fff06f1e28fd633f5bb0048f
tree17ed0ce29d6d081af15e02220d89c3f741ceb7d6
parent481014ac9edf0e79601140727c2be817b1f72c12
dialog: Check whether text changed when setting title or description

As usually with GObject setters, we should check whether the property
actually changed before setting the value and notifying the property. So
check whether the title or description text actually changed before
setting it.

This fixes a bug which makes the title flicker and change its size,
because when updating the title we remove the "leightweight" css class
and reapply it inside a later, which makes the title appear larger for
one frame.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2574

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1336
js/ui/dialog.js